Fix ssl_transport_security_test.cc when built against OpenSSL 1.0.2.#25843
Merged
matthewstevenson88 merged 6 commits intogrpc:masterfrom Mar 31, 2021
Merged
Conversation
This reverts commit 383c247.
Contributor
|
As a side note, |
Contributor
Author
Sure, I'll take a look before submitting this PR. Is it always a timeout, like in the case of the Bazel RBE TSAN C/C++ failure? |
Contributor
Author
|
Update: the ssl_tsi_test_do_round_trip_odd_buffer_size test is super slow (because it runs many many times), so we need to decrease the number of test runs when using TSAN. Otherwise, this test will timeout. |
This was referenced Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the errors found by PR #25770, namely it enables
ssl_transport_security_test.ccto build and have its test pass when built against OpenSSL 1.0.2.Note that there are still some tests that fail when built against OpenSSL 1.0.2.
Relevant issue: #24960