Skip to content

Revert "Convert grpc_ares_wrapper to C++ (#25108)"#25761

Merged
apolcyn merged 1 commit intogrpc:masterfrom
apolcyn:rollback_ares_cpp
Mar 19, 2021
Merged

Revert "Convert grpc_ares_wrapper to C++ (#25108)"#25761
apolcyn merged 1 commit intogrpc:masterfrom
apolcyn:rollback_ares_cpp

Conversation

@apolcyn
Copy link
Copy Markdown
Contributor

@apolcyn apolcyn commented Mar 18, 2021

This reverts commit 2ee7017.

Some problems found internally with this, see b/183105719

@apolcyn apolcyn requested a review from markdroth as a code owner March 18, 2021 20:57
@apolcyn apolcyn added lang/core release notes: no Indicates if PR should not be in release notes labels Mar 18, 2021
@veblush veblush self-requested a review March 18, 2021 21:12
@apolcyn
Copy link
Copy Markdown
Contributor Author

apolcyn commented Mar 19, 2021

basic tests C windows is internal issue: b/170748763
basic tests ruby is internal issue: b/178198736
obc ios: #25765
C/C++ opt macos has no test result page but is listed as broken here

@apolcyn apolcyn merged commit a988190 into grpc:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants