Initial prototype of C# wrapping layer for C core library#247
Initial prototype of C# wrapping layer for C core library#247jtattermusch wants to merge 67 commits intogrpc:masterfrom jtattermusch:wrappers_review
Conversation
|
ctiller, can you please review the grpc_csharp_ext.c file? |
|
I'm going to bow-out of this CR. The scope of the CL is bigger than I have On Thu, Jan 29, 2015 at 1:47 PM, Jan Tattermusch notifications@github.com
|
|
Sure, thanks for valuable comments! On Thu, Jan 29, 2015 at 1:51 PM, kennetatgoogle notifications@github.com
|
|
I'll have a bit of latency for a day or so while I get some complex changes finished up. |
|
Please ignore this pull request, I will have newer and cleaner version of C# code to push soon. |
There was a problem hiding this comment.
I suggest moving all DllImport declarations into a NativeMethods class, as per https://msdn.microsoft.com/en-us/library/ms182161.aspx, instead of declaring the methods in each class that uses them.
There was a problem hiding this comment.
Ok, makes sense. This pull request has already been closed, but I will revisit this once I get things running on Windows (gRPC C Core didn't compile there until short time ago).
Code for wrapping gRPC C core library is in GrpcWrappers project. Rest of the code is provided for reference.