Skip to content

Add missing Foundation.h import to generated Objective-C code#24027

Closed
pbatg wants to merge 2 commits intogrpc:masterfrom
pbatg:master
Closed

Add missing Foundation.h import to generated Objective-C code#24027
pbatg wants to merge 2 commits intogrpc:masterfrom
pbatg:master

Conversation

@pbatg
Copy link
Copy Markdown
Contributor

@pbatg pbatg commented Aug 31, 2020

@yulin-liang This #import is needed when using GPB_GRPC_PROTOCOL_ONLY

@yulin-liang yulin-liang added the release notes: no Indicates if PR should not be in release notes label Aug 31, 2020
@yulin-liang yulin-liang self-assigned this Aug 31, 2020
@yulin-liang yulin-liang self-requested a review August 31, 2020 18:02
@yulin-liang
Copy link
Copy Markdown
Contributor

yulin-liang commented Sep 2, 2020

The broken python test is a known issue: #23028

But the followingSanity Checks issue need to be fixed:

--- /var/local/git/grpc/src/compiler/objective_c_plugin.cc	2020-09-02 02:22:06.645932000 +0000
+++ /tmp/tmp.6NdgNUgqw9	2020-09-02 02:26:15.509932000 +0000
@@ -236,8 +236,7 @@
       }

       Write(context, file_name + ".pbrpc.h",
-            file_header +
-                SystemImport("Foundation/Foundation.h") + "\n" +
+            file_header + SystemImport("Foundation/Foundation.h") + "\n" +
                 PreprocIfNot(kForwardDeclare, imports) + "\n" +
                 PreprocIfNot(kProtocolOnly, system_imports) + "\n" +
                 class_declarations + "\n" +

@pbatg pbatg mentioned this pull request Sep 2, 2020
Merged
@pbatg
Copy link
Copy Markdown
Contributor Author

pbatg commented Sep 2, 2020

Amending this commit was difficult because it was pushed to the master branch, so I've created a new PR: #24049

@pbatg pbatg closed this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yulin-liang yulin-liang yulin-liang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yulin-liang yulin-liang

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pbatg @yulin-liang @grpc-kokoro