Generate upbdefs file in upb codegen and put them in src/core/ext/upbdefs-generated#23904
Merged
jtattermusch merged 7 commits intogrpc:masterfrom Aug 21, 2020
Merged
Conversation
dbd91c6 to
80252ec
Compare
Contributor
Author
|
@markdroth I still might update a few infrastructure scripts, but this is mostly ready - let's see what the test say. |
markdroth
approved these changes
Aug 20, 2020
Contributor
Author
|
Known failures: #23028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for now the upbdefs files will stay unused.
Review tip: generated code is in separate commits to simplify review.