Backport of #23765 to v1.31.x branch#23830
Merged
stanley-cheung merged 3 commits intogrpc:v1.31.xfrom Aug 14, 2020
Merged
Conversation
Merged
apolcyn
approved these changes
Aug 14, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to backport the #23765 fix to the
v1.31.xbranch.The main fix is to add this
"."in front of the fully qualified proto message name, so that it will be converted into an absolute path starting with::as the Ruby package name. See this comment and this comment for the rationale for the fix.There are new tests added in the PR.
We also ran the
src/ruby/pb/generate_proto_ruby.shscript to re-generate some generated files that will be updated by this protoc plugin change.