Move parse_address library from client_channel to iomgr.#23820
Merged
markdroth merged 1 commit intogrpc:masterfrom Aug 18, 2020
Merged
Move parse_address library from client_channel to iomgr.#23820markdroth merged 1 commit intogrpc:masterfrom
markdroth merged 1 commit intogrpc:masterfrom
Conversation
84c4796 to
04e15ff
Compare
04e15ff to
bd73844
Compare
yashykt
approved these changes
Aug 18, 2020
Member
Author
|
Green! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll need to use this in the xDS code for the gRPC server, so it's no longer going to be specific to the client channel code. Also, it has some
#defines that probably shouldn't be used outside of the iomgr tree anyway.