Allow bazel builds without xDS via "--define grpc_no_xds=true".#23658
Merged
markdroth merged 1 commit intogrpc:masterfrom Sep 3, 2020
Merged
Allow bazel builds without xDS via "--define grpc_no_xds=true".#23658markdroth merged 1 commit intogrpc:masterfrom
markdroth merged 1 commit intogrpc:masterfrom
Conversation
93796a7 to
577fe7e
Compare
577fe7e to
9387fb1
Compare
Contributor
|
Mirroring my internal comment here: At first I was making a big comment about how I didn't necessarily like the fact this is an #ifndef and why, but after lots of reflection on it, I think this one might be the way we want it to be. We need to keep in mind tho that #ifdef should be preferred over #ifndef. |
nicolasnoble
approved these changes
Aug 28, 2020
9387fb1 to
79f8fc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.