Closed
Conversation
d39223b to
4f6d6d8
Compare
Contributor
Author
|
Closing this for now so that new pushes to this branch won't trigger test runs, which are failing right away now because of conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #23533 plus a PHP fix on the failed Artifacts build issue.
This PR adds a script to be run before we build the PHP extension .tgz archive. The script tries to rename filenames like
a.upbdefs.c|htoa_upbdefs.c|h, and all their references, to avoid a specific PHP build issue where the PHP build process is generating conflictMakefilebuild target for these pair of files. See more details at #23307.This is just a test run. I will work with Mark to see how I can incorporate my change into #23533.