Uses sources.json from BoringSSL#23568
Conversation
This change undoes some hackiness that relied on specifics of the BoringSSL build system to generate source files. With the latest github mirror of BoringSSL exports a sources.json that lists all source code files. This change makes use of that file.
|
Locally sanity tests seem to be failing on format issues. I'm trying to fix them. |
|
Actually format issues looks like it is for an unrelated file: "./test/cpp/qps/json_run_localhost_scenarios.bzl" |
|
Can you rerun the generation script? Sometimes I see the formatting complain of that file. If the complain persists, can you share the log? |
I reran: |
lidizheng
left a comment
There was a problem hiding this comment.
LGTM. @jtattermusch Can you please also take a look?
remove space.
|
Going ahead to merge this PR since all tests in CI passes. I hope the BoringSSL optimization can be included in our next release. The time until next release should give us a chance to catch potential issue. |
|
@emkornfield Awkwardly, the boringssl-with-bazel library is not available in google3. But the gen_build_yamp.py needs to be ran in both environments. Can you create a roll forward PR without directly depending on |
|
@lidizheng can you clarify if output is important or just a non zero exit code |
|
The output is important. It generates the yaml file that both Bazel and Blaze reads. |
|
Can you send directions on how to test in google3 |
|
@emkornfield There isn't a straightforward way to test this. If a PR is merged. You can initiate an import by running Or you can create a one PR import CL from go/grpc-cherrypick. It's a bit more complex, since it needs to get the ref commit hash for rebase. This approach only works for unmerged PRs. |
This change undoes some hackiness that relied
on specifics of the BoringSSL build system to
generate source files. With the latest github
mirror of BoringSSL exports a sources.json
that lists all source code files. This change
makes use of that file.
I ran "./tools/buildgen/generate_projects.sh" and no changes are
generated with this change.
@lidizheng @jtattermusch