Try fix missing upb.hpp in python source wheel.#23563
Try fix missing upb.hpp in python source wheel.#23563jtattermusch wants to merge 4 commits intogrpc:masterfrom
Conversation
|
Adhoc distribtest flow: https://g3c.corp.google.com/results/invocations/7a9a3047-95ec-4b14-9607-1a80d2f6532b |
|
Resulting grpcio-1.31.0.dev0.tar.gz for the adhoc build https://pantheon.corp.google.com/storage/browser/grpc-testing-kokoro-prod/test_result_public%2Fprod%2Fgrpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_build_packages%2F13059%2F20200721-041828%2Fgithub%2Fgrpc%2Fartifacts%2F still doesn't contain the .hpp files, looks like python is actively resisting adding them. |
|
I think I found the real reason why upb.hpp is not included in the python source wheel and it's really wicked :-) I think I'm testing a fix right now. |
|
I verified locally that the file upb.hpp is not missing anymore from the sdist package. I started another adhoc distribtest flow to double check: |
|
Created a separate PR with a fix: #23565 |
|
All distribtests are passing: https://sponge.corp.google.com/target?id=eb9511e8-30f4-41ff-8847-76b105f84a30&target=grpc%2Fcore%2Fexperimental%2Fgrpc_distribtests_multiplatform&searchFor= (which also means that both #23552 and #23565 are good fixes). |
Based on #23552