Merged
Conversation
c935d28 to
a5dd172
Compare
Contributor
Author
|
grpc_build_artifacts_multiplatform: passed except ruby |
Contributor
Author
|
With #23378, msan failures became better and remaining failures are
|
0eb934d to
8260c25
Compare
Contributor
Author
|
With #23379, msan failures are all gone but chances are that h2 failures can come back since I haven't made any change on them. |
8260c25 to
a6b75af
Compare
Contributor
Author
|
Tested with #23344: grpc_build_artifacts_multiplatform: passed except existing upb failures |
a6b75af to
dfd96da
Compare
Contributor
Author
|
grpc_build_artifacts_multiplatform: passed except existing python errors |
dfd96da to
2bc76cf
Compare
This was referenced Jul 18, 2020
08c198f to
21b36d3
Compare
Contributor
Author
21b36d3 to
e646f52
Compare
e646f52 to
1338cce
Compare
1338cce to
3ac116f
Compare
Contributor
Author
|
All failures from |
yang-g
approved these changes
Jul 28, 2020
Contributor
yang-g
left a comment
There was a problem hiding this comment.
Please do a cherry pick import to make sure it does not break internal stuff. Thanks.
Contributor
Author
|
@yang-g Thanks! I already pressed the merge button but I'm running the test internally. |
This was referenced Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since all major requirements for enabling
GPR_ABSEIL_SYNCare merged, it's time to turn this on. Notably two things were addressed;Hardening the Linux build environments for wrapped languages. In a nutshell, all Linux build systems are now leveraging
manylinux2010or its variants to build most compatible artifacts. Ruby was the last one to employ this. (Ruby docker image based on manylinux2010 #23344).Making exit code of tests more strict about joining the gRPC thread. Because Abseil uses a global variable in implementing its locks, it became more susceptible to MSAN because existing gRPC tests used to leave the gRPC threads running at the end of the test. These had to be modified like the main test function waiting until all the gRPC threads terminate. (Added call to grpc::testing::TestEnvironment in tests #23378)
Now all lock implementation on gRPC starts to use Abseil by default. Once this is proven safe via the upcoming releases, all gRPC-specific lock implementation will be removed and Abseil will be used at all times.