Prevent another exception spam in _ChannelCallState.__del__#23201
Merged
lidizheng merged 1 commit intogrpc:masterfrom Jun 12, 2020
Merged
Prevent another exception spam in _ChannelCallState.__del__#23201lidizheng merged 1 commit intogrpc:masterfrom
lidizheng merged 1 commit intogrpc:masterfrom
Conversation
gnossen
approved these changes
Jun 12, 2020
Contributor
gnossen
left a comment
There was a problem hiding this comment.
And this is one of the major problems with __del__. You don't get many guarantees about what state your object (or the process) is in when it's called.
This was referenced Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.
This issue originated from google3 (b/158863508), where the GC might behave slightly different than OSS. In theory, this function should hold reference against
cygrpcandcygrpc.StatusCode. It's surprising that the dependencies of_ChannelCallState.__del__being deallocated earlier than itself.Overall, Python's GC is working fine in the runtime. Indeterministic behaviors only observed during interpreter shutdowns. The google3 issue is no exception. I have manually tested that this corner case is fixed by this PR.
If there is another spam, we should consider suppress the exception instead of patching up corner cases. (Error suppression considered harmful for project's debuggability.)