Pin version of RSA package to avoid bad releases#23197
Pin version of RSA package to avoid bad releases#23197lidizheng merged 5 commits intogrpc:masterfrom
Conversation
|
I hope it's fixed now! If there are still issues, please let me know. |
|
@sybrenstuvel Thanks for the quick update. From my local experiments, (Now, the |
|
FYI, we just released google-auth 1.17.2 with a more restricted pin https://github.com/googleapis/google-auth-library-python/blob/b74168b710da38c0cf06cdf8685c49af4748e3a0/setup.py#L25-L26 |
|
@lidizheng I wonder whether we need to backport this fix to the |
|
@stanley-cheung We won't need to backport this. The breakage is only impacting our test infrastructure. The bad release comes from This PR is a more or less a bandage, long term solution is #23200. |
Fix #23190 #23188
The cause: sybrenstuvel/python-rsa#152
The
rsarelease 4.1.1 and 4.2 dropped Python 2 support, which is a legit move. However, they didn't update the corresponding classifier in theirsetup.py. So, the PyPI offers py2-incompatible packages to Python 2 users and caused the breakage.We don't directly depend on
rsa. Thegoogle-authlibrary incurs dependency onrsa, which unfortunately was needed for our tests.