Avoid attribute error in __del__ of _ChannelCallState#23176
Merged
lidizheng merged 1 commit intogrpc:masterfrom Jun 11, 2020
Merged
Avoid attribute error in __del__ of _ChannelCallState#23176lidizheng merged 1 commit intogrpc:masterfrom
lidizheng merged 1 commit intogrpc:masterfrom
Conversation
gnossen
approved these changes
Jun 10, 2020
This was referenced Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a reported crash that in the the
__del__of_ChannelCallState, theself.channelattribute becomesNone, and causedAttributeError.During the deallocation,
Channelis deallocated before_ChannelCallState, which caused this issue.