use Microsoft.NETFramework.ReferenceAssemblies for Grpc.Tools#23174
Merged
jtattermusch merged 3 commits intogrpc:masterfrom Jun 16, 2020
Merged
use Microsoft.NETFramework.ReferenceAssemblies for Grpc.Tools#23174jtattermusch merged 3 commits intogrpc:masterfrom
jtattermusch merged 3 commits intogrpc:masterfrom
Conversation
jtattermusch
commented
Jun 10, 2020
| <FrameworkPathOverride Condition="Exists('/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/4.5-api')">/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/4.5-api</FrameworkPathOverride> | ||
| </PropertyGroup> | ||
| <!-- Needed for the net45 build to work on Unix. See https://github.com/dotnet/designs/pull/33 --> | ||
| <ItemGroup> |
Contributor
Author
There was a problem hiding this comment.
note that this is the recommended way of making net45 build work with pure dotnet SDK.
We already use it here (and Grpc.Tools and Grpc.Tools.Tests are the only remaining project that still use the old hack):
apolcyn
approved these changes
Jun 12, 2020
Contributor
Author
|
Still failing under MacOS, but it should be an easy fix: https://source.cloud.google.com/results/invocations/9add43eb-6457-4d98-851b-d2743c1f3194/targets/github%2Fgrpc%2Frun_tests%2Fcsharp_macos_dbg_native%2Fcsharp.Grpc.Tools.Tests.CppGeneratorTest/tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main motivation is to make everything buildable using dotnet SDK even if mono is not installed.