Skip to content

Use upb_proto_library rule to dynamically generate upb codegen in bazel builds#23122

Closed
markdroth wants to merge 71 commits intogrpc:masterfrom
markdroth:upb_upgrade.alt
Closed

Use upb_proto_library rule to dynamically generate upb codegen in bazel builds#23122
markdroth wants to merge 71 commits intogrpc:masterfrom
markdroth:upb_upgrade.alt

Conversation

@markdroth
Copy link
Copy Markdown
Member

@markdroth markdroth commented Jun 3, 2020

No description provided.

@markdroth markdroth changed the title Upb upgrade.alt Use upb_proto_library rule to dynamically generate upb codegen in bazel builds Jun 4, 2020
@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Jun 8, 2020
@markdroth
Copy link
Copy Markdown
Member Author

I've updated this to merge in the changes from when we did the upb upgrade and started using the upbdefs files. The project is temporarily on hold until we can resolve some internal dependency issues.

The main thing that we still need to resolve here is to fix the non-bazel builds. We can pick that up again when we're ready to proceed.

@jtattermusch
Copy link
Copy Markdown
Contributor

I wanted to check whether this PR would be compatible with splitting upb generated filed into upb-generated and upbdefs-generated directories (see #23835), but to be honest the ideas in this PR are very hard to follow when description of this PR is empty.
It would be good if there was a short list of things that this PR plans to do - I understand that for bazel build we probably want to start relying on upb_proto_library rules, but it's unclear to me how codegen and source file includes is intended to be handled for other build systems (do we still plan to check in upb generated files? - I guess we have to).

So far I haven't seen anything that would categorically prevent changes from #23835 from working with this PR (with some adjustments) but as I said I don't the ideas behind this PR 100% so it's hard to tell.

@stale
Copy link
Copy Markdown

stale bot commented Dec 8, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

@stale stale bot closed this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition/stale release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants