Skip to content

tools/dockerfile: Run Java build twice to reduce flakiness#22921

Merged
ejona86 merged 1 commit intogrpc:masterfrom
ejona86:java-interop-try-again
May 11, 2020
Merged

tools/dockerfile: Run Java build twice to reduce flakiness#22921
ejona86 merged 1 commit intogrpc:masterfrom
ejona86:java-interop-try-again

Conversation

@ejona86
Copy link
Copy Markdown
Member

@ejona86 ejona86 commented May 11, 2020

Downloads fail from time to time because Gradle does not retry certain
types of network failures
(gradle/gradle#8264).

Retrying twice should reduce the flake rate below noticeable without
increasing the size of the interop image created for each new release
for historical testing.

Fixes #18892


I'm doing this version in favor of #22902 to avoid increasing the size of the release interop images, which have a long lifetime.

Downloads fail from time to time because Gradle does not retry certain
types of network failures
(gradle/gradle#8264).

Retrying twice should reduce the flake rate below noticeable without
increasing the size of the interop image created for each new release
for historical testing.

Fixes grpc#18892
@ejona86 ejona86 added the release notes: no Indicates if PR should not be in release notes label May 11, 2020
@ejona86 ejona86 requested a review from apolcyn May 11, 2020 18:43
Copy link
Copy Markdown
Contributor

@apolcyn apolcyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ejona86 ejona86 merged commit 3d8d1c8 into grpc:master May 11, 2020
@ejona86 ejona86 deleted the java-interop-try-again branch May 11, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAILURE: build_docker_java

2 participants