Avoid collisions in cs files generated by Grpc.Tools#22852
Closed
jtattermusch wants to merge 1 commit intogrpc:masterfrom
Closed
Avoid collisions in cs files generated by Grpc.Tools#22852jtattermusch wants to merge 1 commit intogrpc:masterfrom
jtattermusch wants to merge 1 commit intogrpc:masterfrom
Conversation
Contributor
Author
Contributor
Author
|
CC @Falco20019 this is my first experiment to fix #17672 (haven't tested it yet). |
Contributor
Author
|
Current version gives |
Falco20019
suggested changes
May 5, 2020
Contributor
Falco20019
left a comment
There was a problem hiding this comment.
I just fixed all of the problems and did some cleanup. Will create a PR for it.
| string grpcdir = DepFileUtil.GetOutputDirWithHash(protoItem.GetMetadata(Metadata.GrpcOutputDir), protoItem.ItemSpec); | ||
| filename = LowerUnderscoreToUpperCamelGrpcWay(basename); | ||
| outputs[1] = Path.Combine( | ||
| grpcdir != "" ? grpcdir : outdir, filename) + "Grpc.cs"; |
Contributor
There was a problem hiding this comment.
This won't be string.Empty anymore as it always includes the hash.
Contributor
Author
|
Superseded by #22869 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just an experiment for now.