Skip to content

Remove gpr_strvec.#22772

Merged
markdroth merged 1 commit intogrpc:masterfrom
markdroth:gpr_strvec
May 21, 2020
Merged

Remove gpr_strvec.#22772
markdroth merged 1 commit intogrpc:masterfrom
markdroth:gpr_strvec

Conversation

@markdroth
Copy link
Copy Markdown
Member

@markdroth markdroth commented Apr 24, 2020 •
edited
Loading

Instead, we use absl::StrJoin().

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Apr 24, 2020
@markdroth markdroth marked this pull request as ready for review May 8, 2020 19:50
@markdroth markdroth requested a review from veblush May 8, 2020 19:50
veblush
veblush approved these changes May 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@veblush veblush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you for refactoring code!

@markdroth
Copy link
Copy Markdown
Member Author

markdroth commented May 21, 2020

Known issues: #23027 #23028

The iOS binary size failure looks like an infrastructure timeout.

@markdroth markdroth merged commit 3db250d into grpc:master May 21, 2020
@markdroth markdroth deleted the gpr_strvec branch May 21, 2020 20:18
@karthikravis
Copy link
Copy Markdown
Contributor

karthikravis commented May 27, 2020

Unfortunately, this seems to be causing an increase in flaky tests --> https://test.corp.google.com/ui#id=OCL:313231035:BASE:313258195:1590537147404:3f51b773 , https://g3c.corp.google.com/results/invocations/2cc3ef83-d8cc-4fac-9f5e-274ee1d88bec/targets/%2F%2Fnet%2Fgrpc%2Fpython:internal_tests%2Funit%2F_borg_signal_handling_test.python2/tests and https://g3c.corp.google.com/results/invocations/2cc3ef83-d8cc-4fac-9f5e-274ee1d88bec/targets/%2F%2Fnet%2Fgrpc%2Fpython:internal_tests%2Funit%2F_borg_signal_handling_test.python3/log

@karthikravis karthikravis mentioned this pull request May 27, 2020
Merged
@markdroth markdroth mentioned this pull request May 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@veblush veblush veblush approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markdroth @karthikravis @veblush