tools: Put sha1 in container tag instead of name#22756
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Apr 24, 2020
Merged
tools: Put sha1 in container tag instead of name#22756jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch merged 1 commit intogrpc:masterfrom
Conversation
Ideally instead of having names like ruby_jessie_x64_ruby_2_5 and ruby_jessie_x64_ruby_2_6 they would have the name "ruby" with tags containing jessie_x64_ruby_2_5/6. But fixing that would be much more invasive. The sha1 in the tag is producing the worst effects, so this is a case of the perfect being the enemy of the good. Fixes grpc#20546
Contributor
|
I started work on this, but never finished it master...jtattermusch:docker_tags_fix_20546 Thanks for stepping in. I'll quickly check for differences between the two branches. |
Contributor
|
Known failures: #22760 |
Member
Author
|
@jtattermusch, oh, I see. It looks like you were re-generating the docker images. Yeah, I can understand how that would slow things down, since it appears things fail to rebuild. I hacked push_testing_images.sh to do a docker pull + docker push under the new name. Even with that it took a long time; we have a lot of images. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally instead of having names like ruby_jessie_x64_ruby_2_5 and
ruby_jessie_x64_ruby_2_6 they would have the name "ruby" with tags
containing jessie_x64_ruby_2_5/6. But fixing that would be much more
invasive. The sha1 in the tag is producing the worst effects, so this is
a case of the perfect being the enemy of the good.
Fixes #20546
I re-pushed the current images under the new name and verified that rebuilding an image works.