Increase timeout for macOS Python tests by 50%#22694
Merged
lidizheng merged 1 commit intogrpc:masterfrom Apr 17, 2020
Merged
Conversation
gnossen
approved these changes
Apr 16, 2020
Contributor
There was a problem hiding this comment.
This shouldn't be caused by additional interpreter versions tested, since I explicitly skipped MacOS for those. I wonder what makes the MacOS tests take so much longer than all the other platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22692
Due to testing more Python versions and more IO manage platform, the macOS Python tests start to timeout. In the long term, we could 1) make tests parallel; 2) or reduce the number of tests.