Fix generating method output with nested resource#22594
Merged
apolcyn merged 2 commits intogrpc:masterfrom May 8, 2020
Merged
Conversation
|
|
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! |
apolcyn
requested changes
May 8, 2020
Contributor
apolcyn
left a comment
There was a problem hiding this comment.
This looks good to me, I just have some comments about formatting. Please address and then I'll approve
| std::string proto_type = descriptor->full_name(); | ||
| ReplacePrefix(&proto_type, package, ""); // remove the leading package if present | ||
| ReplacePrefix(&proto_type, ".", ""); // remove the leading . (no package) | ||
|
|
Contributor
There was a problem hiding this comment.
please delete unnecessary blank line, here and below.
| inline grpc::string RubyTypeOf(const grpc::protobuf::Descriptor* descriptor, | ||
| const grpc::string& package) { | ||
| std::string proto_type = descriptor->full_name(); | ||
| ReplacePrefix(&proto_type, package, ""); // remove the leading package if present |
Contributor
There was a problem hiding this comment.
please address clang format suggestion:
- ReplacePrefix(&proto_type, package, ""); // remove the leading package if present
- ReplacePrefix(&proto_type, ".", ""); // remove the leading . (no package)
+ ReplacePrefix(&proto_type, package,
+ ""); // remove the leading package if present
+ ReplacePrefix(&proto_type, ".", ""); // remove the leading . (no package)
apolcyn
approved these changes
May 8, 2020
gnossen
approved these changes
May 8, 2020
This was referenced Jul 16, 2020
[Ruby] grpc_tools_ruby_protoc generates wrong namespace for fully-qualified rpc response type
#23490
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21561
Fix to use
descriptor->full_name()removed package name instead ofdescriptor->name()when using theruby_packageoption.@apolcyn