Replaced grpc::string with std::string#22190
Closed
veblush wants to merge 3 commits intogrpc:masterfrom
Closed
Conversation
yang-g
reviewed
Feb 29, 2020
yang-g
reviewed
Feb 29, 2020
mhaidrygoog
approved these changes
Feb 29, 2020
yang-g
reviewed
Feb 29, 2020
karthikravis
approved these changes
Feb 29, 2020
vjpai
approved these changes
Mar 6, 2020
vjpai
suggested changes
Mar 6, 2020
| typedef GRPC_CUSTOM_STRING string; | ||
|
|
||
| using std::to_string; | ||
| // Using std::string and std::to_string is discouraged in favor of |
Contributor
There was a problem hiding this comment.
Change this to using grpc::string and grpc::to_string is discouraged ....
vjpai
approved these changes
Mar 6, 2020
Contributor
vjpai
left a comment
There was a problem hiding this comment.
Approving in advance but please resolve my concern in the previous review. I don't have any further comments.
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
grpc::stringwas configurable with given custom string type but this indirection added more complexity and this would be better to be replaced with explicitstd::string. Since we started usingstd::stringin gRPC Core, this helps us to have better code readability with just one string representation.grpc_build_artifacts_multiplatform: passed