Add ruby-2.7 to build process of binary gems for Windows and Linux#22039
Merged
veblush merged 1 commit intogrpc:masterfrom Feb 24, 2020
Merged
Add ruby-2.7 to build process of binary gems for Windows and Linux#22039veblush merged 1 commit intogrpc:masterfrom
veblush merged 1 commit intogrpc:masterfrom
Conversation
With rake-compiler-dock-1.0.1 there's no need to use a derived Dockerfile. The standard RCD image can be used instead. The only issue is with conflicting declarations of gettimeofday(), which can be easily worked around by patching win32.h before the build. Fixes grpc#21514
|
|
Contributor
Author
|
I just signed the CLA and hope it works. |
Contributor
|
Great! Thank you for the PR. I'll run the test for verifying artifacts. Distribute testgrpc_build_artifacts_multiplatform: passed for ruby and ruby gem files are built and stored in dir
|
veblush
approved these changes
Feb 17, 2020
Contributor
|
Waiting for the one more approval to get it merged. |
nicolasnoble
approved these changes
Feb 24, 2020
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a alternative PR to #22014 . I didn't notice it until I opened this PR. Still I think this is the better way since it removes now needless
Dockerfiles. It also fixes a circular dependency that happens when re-running the build.With rake-compiler-dock-1.0.1 there's no need to use a derived
Dockerfile. The standard RCD image can be used instead. The only issue is with conflicting declarations ofgettimeofday(), which can be easily worked around by patching win32.h before the build.I manually tested installing and loading the gem in
irbonx86-mingw32,x64-mingw32andx86_64-linux.Fixes #21514
@veblush , @nicolasnoble