get rid of the https://grpc.io/release plague#21891
Conversation
|
I'm not against this change in principle, but I wanted to point out that your second and third bullets are criticisms of our current release process, not of the FWIW, it's actually defined here in the old site's repo, via a redirect in the new site. Personally, I'd prefer to just get rid of the redirect and make updating the tag on the new site a part of the release manager's document. |
|
This was broken since the time grpc.io website was updated. We have been updating the document every release as it is part of the release process now and it not a big overhead to do that. See config.toml in grpc/grpc.io. It shows: I am not totally convinced that this needs to go. I think this is a nice way to point to the latest stable release instead of asking users to replace RELEASE_TAG_HERE in various instructions. Beginners like to just cut and paste. |
|
This should fix the redirect and break the dependency on the old site. |
|
@gnossen thanks for the fix. @srini100 I understand that the idea is to make the commands copy-and-pastable, which is useful, but I think that the argument that the resulting command is not very readable (as a beginner, I can imagine being confused about what the subcommand $(curl -L ...) does). Btw, on windows, the readability issue is much more apparent - the original command Besides that, I'd understand if we used this "get the latest version" trick in one or two places in the repo (the actual getting started docs), but seeing it copy pasted in many different places that have a different (e.g. loadbalancing tutorial) focus seems off. Btw, for the tutorials on grpc.io page, things work better because the page renders the right version number automatically - that a much better approach and it doesn't impose intellectual burden on the user. |
|
@jtattermusch An alternate approach would be to start updating a mutable |
I am not a fan of that either. None of the open source projects I know of does this. |
srini100
left a comment
There was a problem hiding this comment.
I am fine to go ahead with this change but let's keep grpc.io the same since it can render the value.
|
@srini100 grpc.io will stay the same in the sense that I will replace occurrences of the curlable link with a token that will be rendered directly into the page. |
Also see internal issue b/148844497
Generally the
curl -L https://grpc.io/releasesubcommand does more harm than goodhttps://grpc.io/releasefile is updated (I didn't figure it out).In short the
https://grpc.io/releaseis harmful and we should get rid of it.