Test this repo against grpc/grpc-node#1239#21702
Test this repo against grpc/grpc-node#1239#21702murgatroid99 wants to merge 2 commits intogrpc:masterfrom
Conversation
44fa164 to
2e3bc97
Compare
|
So, @veblush, the node test was broken here reporting no problem (see grpc/grpc-node#1239 - the upb submodule change broke it), which means a few build issues cropped since this happened. One of them being this: This probably is something we want to double-file with abseil. The gist is that if you try to create a static library under macos using XCode with the same filename twice, one will get ignored or overridden by the other one, even if they come from different sub directories. I am guessing this issue with |
|
Hopefully we can get abseil/abseil-cpp#605 in, to fix the next breakage on this PR. |
|
Thank you for the report. This is interesting but I think it could be a bit out-dated warning. The warning was needed before with msvc2008 and mac make with libtool on mac and it has been considered to remove this check as no one is actively using those. Is it possible to use Reference: |
|
@veblush: if this was working, sure: nodejs/node-gyp#2026 |
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! |
Background: The Node test jobs in this repo's PRs run this script in the node repository, passing a commit reference for the commit in the PR. That script is missing a
set -eline and recently the command to check out the submodule commit has been failing because of some changes made to thethird_party/upb. As a result of that combination of problems, the script has been silently testing the current state of the grpc-node repository, instead of the state corresponding to updating the submodule with the contents of the PR.This PR runs the Node test job against grpc/grpc-node#1239, which fixes those problems. There are other known integration problems, so the Node test job for this PR will fail initially.