WIP: Bazel distribtest improvements#21668
Conversation
|
CC @gnossen in case you have some early comments. |
gnossen
left a comment
There was a problem hiding this comment.
Nice improvement! Which kokoro job is this getting picked up by?
| @@ -1,3 +1,12 @@ | |||
| # We use "local_repository()" to test against the checked-out version of gRPC | |||
| @@ -0,0 +1,86 @@ | |||
| /* | |||
There was a problem hiding this comment.
Optional: Any chance we could do a symlink instead of a hard copy of the example files? Piper definitely has trouble with symlinks, so we'd have to make sure copybara didn't pick these files up, but since this should be an OSS-only directory, I think that should be fine.
| #include <grpcpp/grpcpp.h> | ||
|
|
||
| #ifdef BAZEL_BUILD | ||
| #include "examples/protos/helloworld.grpc.pb.h" |
There was a problem hiding this comment.
This path doesn't seem quite right given the directory structure of this new test.
4c3f044 to
0008daa
Compare
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! |
WIP for now, but eventually we should have both bazel distribtest running under the distribtest suite.