Make bazel test sharding work for poller-specific tests#21294
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Nov 26, 2019
Merged
Make bazel test sharding work for poller-specific tests#21294jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch merged 1 commit intogrpc:masterfrom
Conversation
Contributor
Author
|
Known failures: |
veblush
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup for #21274 that will actually fix #20695.
Without this, the xds_end2end_test won't actually be sharded (we're still getting the "unevaluated target" problem on master and there is only one shard: https://source.cloud.google.com/results/invocations/e7b604d6-74d2-4f6c-8768-733889379b9e/targets)
Can be verified manually with
bazel --bazelrc=tools/remote_build/manual.bazelrc test --config=ubsan //test/cpp/end2end:xds_end2end_test@poller=epollex