Workaround the ExternalDnsWithTracingClientServerTest flake on Linux#21179
Merged
jtattermusch merged 2 commits intogrpc:masterfrom Nov 14, 2019
Merged
Conversation
apolcyn
approved these changes
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18126
I've done quite a bit of experimenting with the test on mono on linux:
The test itself always finishes fine, but the mono binary gets stuck on shutdown. I attached gdb and didn't see anything suspicious and it seemed that all the managed threads have finished. My theory is that the binary fails to exit because of this:
The workaround is to disable the logging/tracing part of the test on Linux and Mac, because we are interested in testing on Windows only anyway (where the test passes reliably, according to the test result history)
The PR also fixes a few typos.