Increase MacOS C/C++ test limit#21152
Merged
jtattermusch merged 2 commits intomasterfrom Nov 13, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase from 2 hours to 3 hours. Note that such test duration is way too much for a quick turnaround of PRs (so I'm not happy at all that we have to increase the timeout), but #20694 has been open for a while and it's one of the main sources of flakiness for macOS PR tests, so we need to fix it somehow.
Hopefully in the long run we will be able to reduce the test latency by using bazel and with other optimizations.
Fixes #20694