Skip to content

Increase MacOS C/C++ test limit#21152

Merged
jtattermusch merged 2 commits intomasterfrom
jtattermusch-patch-1
Nov 13, 2019
Merged

Increase MacOS C/C++ test limit#21152
jtattermusch merged 2 commits intomasterfrom
jtattermusch-patch-1

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

Increase from 2 hours to 3 hours. Note that such test duration is way too much for a quick turnaround of PRs (so I'm not happy at all that we have to increase the timeout), but #20694 has been open for a while and it's one of the main sources of flakiness for macOS PR tests, so we need to fix it somehow.

  • Due to a kokoro problem, whenever the kokoro job timeout happens on mac, the log is flooded with a lots of "file has vanished" messages, which basically renders the test result unusable, so hitting this timeout is particularly annoying for the developers.

Hopefully in the long run we will be able to reduce the test latency by using bazel and with other optimizations.

Fixes #20694

@jtattermusch jtattermusch added lang/c++ release notes: no Indicates if PR should not be in release notes labels Nov 13, 2019
@veblush veblush self-requested a review November 13, 2019 16:31
Copy link
Copy Markdown
Contributor

@veblush veblush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jtattermusch jtattermusch merged commit f20125c into master Nov 13, 2019
@veblush veblush deleted the jtattermusch-patch-1 branch January 17, 2020 16:39
@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lang/c++ release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FLAKE: MacOS C++ test " ERROR: Aborting VM command due to timeout of 7200 seconds"

2 participants