Put a 2-second deadline on ALTS handshake RPCs#20687
Closed
apolcyn wants to merge 11 commits intogrpc:masterfrom
Closed
Put a 2-second deadline on ALTS handshake RPCs#20687apolcyn wants to merge 11 commits intogrpc:masterfrom
apolcyn wants to merge 11 commits intogrpc:masterfrom
Conversation
2c191dd to
b43298f
Compare
b43298f to
b8c0703
Compare
b8c0703 to
9cfddae
Compare
fc2db68 to
e7a6aeb
Compare
f702741 to
d2690d2
Compare
d2690d2 to
056fbed
Compare
e5c5670 to
6278b50
Compare
Contributor
Author
|
Dropping this in favor of #20929 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #20596
ALTS handshakes can get stuck e.g. until subchannel connect deadlines expire, for different reasons (e.g. a slow or non-responsive peer). When that happens, these handshakes are susceptible to holding up resources and preventing other, otherwise-independent ALTS handshakes from making progress.
The new
test_handshake_fails_within_short_deadline_when_peer_endpoint_is_non_responsive_after_acceptingtest here is meant to try to illustrate this.Note follow-up PR on top of this one: #20722