make cmake grpc.pc depend on openssl too#20621
Merged
markdroth merged 1 commit intogrpc:masterfrom Oct 16, 2019
Merged
Conversation
markdroth
approved these changes
Oct 16, 2019
jtattermusch
commented
Oct 16, 2019
| "${gRPC_CORE_VERSION}" | ||
| "gpr" | ||
| "gpr openssl" | ||
| "-lgrpc -laddress_sorting -lcares -lz" |
Contributor
Author
There was a problem hiding this comment.
@zackgalbreath it would be nice to determine the list of dependencies based on our actual dependencies. Like this we have to maintain several versions of the same list.
nicolasnoble
approved these changes
Oct 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentative fix for #20606 (comment)
The idea is that in the distribtest, we rely on system-installed openssl, but pkgconfig file doesn't reflect that. I have no idea why this has only been triggered by #20606.
This PR adds "openssl" to the grpc.pc "Requires"
CC @markdroth @zackgalbreath @nicolasnoble