Skip service_config_test on old libstdc++ versions#20513
Merged
hcaseyal merged 1 commit intogrpc:masterfrom Oct 16, 2019
Merged
Skip service_config_test on old libstdc++ versions#20513hcaseyal merged 1 commit intogrpc:masterfrom
hcaseyal merged 1 commit intogrpc:masterfrom
Conversation
markdroth
approved these changes
Oct 15, 2019
Member
markdroth
left a comment
There was a problem hiding this comment.
Have we verified that this test actually runs in our presubmits?
Contributor
Author
|
@markdroth Yep, I just pushed a bad commit that returns an error from service config if that branch in the macro is not taken, and I see the service config tests failing on the presubmit for this PR: https://source.cloud.google.com/results/invocations/38239b74-c1d5-4ef8-bc4b-45604f5c604b/targets |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the proper fix for #20318