Skip to content

Add upb#19795

Merged
veblush merged 1 commit intogrpc:masterfrom
veblush:go-upb
Aug 7, 2019
Merged

Add upb#19795
veblush merged 1 commit intogrpc:masterfrom
veblush:go-upb

Conversation

@veblush
Copy link
Copy Markdown
Contributor

@veblush veblush commented Jul 30, 2019 •
edited
Loading

In addition to having upb enabled with bazel, there are many things to be done to use it fully with gRPC. All wrapped language should support it. Since each language uses different build system, they need to be changed even though there is a build.yaml.

NOTE: Because grpc_upb_proto_library rule has a problem internally, regular rules using pre-generated upb files are used temporary instead of grpc_upb_proto_library.

@veblush veblush requested a review from nicolasnoble July 30, 2019 17:00
@veblush veblush added the release notes: no Indicates if PR should not be in release notes label Jul 30, 2019
@veblush veblush requested a review from AspirinSJL July 30, 2019 17:03
@veblush veblush force-pushed the go-upb branch 9 times, most recently from a3a340b to f3ab041 Compare July 31, 2019 22:40
@veblush veblush marked this pull request as ready for review July 31, 2019 23:28
@veblush
Copy link
Copy Markdown
Contributor Author

veblush commented Aug 1, 2019 •
edited
Loading

This is ready to be merged since all tests except some flaky ones are green. The last blocker is the internal import issue which upb rule doesn't support //buildenv/target:gce and //buildenv/target:vendor. (ref: cl/261002331)

@veblush veblush force-pushed the go-upb branch 8 times, most recently from d10e7dc to 8f061d6 Compare August 6, 2019 21:28
@veblush veblush merged commit 0e9a736 into grpc:master Aug 7, 2019
@veblush veblush deleted the go-upb branch August 7, 2019 00:14
@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Aug 7, 2019

This broke the macos distribtest for php

https://source.cloud.google.com/results/invocations/2d47bc90-fe0e-4a59-9dae-4eda0c60bcb7/targets/github%2Fgrpc/tests

 cc -fvisibility=hidden -DOPENSSL_NO_ASM -D_GNU_SOURCE -DWIN32_LEAN_AND_MEAN -D_HAS_EXCEPTIONS=0 -DNOMINMAX -DGRPC_ARES=0 -DGRPC_POSIX_FORK_ALLOW_PTHREAD_ATFORK=1 -I. -I/Volumes/BuildData/tmpfs/tmp/pear/install/grpc -DPHP_ATOM_INC -I/Volumes/BuildData/tmpfs/tmp/pear/install/pear-build-rootxIj7Ik/grpc-1.24.0dev/include -I/Volumes/BuildData/tmpfs/tmp/pear/install/pear-build-rootxIj7Ik/grpc-1.24.0dev/main -I/Volumes/BuildData/tmpfs/tmp/pear/install/grpc -I/usr/include/php -I/usr/include/php/main -I/usr/include/php/TSRM -I/usr/include/php/Zend -I/usr/include/php/ext -I/usr/include/php/ext/date/lib -I/Volumes/BuildData/tmpfs/tmp/pear/install/grpc/include -I/Volumes/BuildData/tmpfs/tmp/pear/install/grpc/src/core/ext/upb-generated -I/Volumes/BuildData/tmpfs/tmp/pear/install/grpc/src/php/ext/grpc -I/Volumes/BuildData/tmpfs/tmp/pear/install/grpc/third_party/address_sorting/include -I/Volumes/BuildData/tmpfs/tmp/pear/install/grpc/third_party/boringssl/include -I/Volumes/BuildData/tmpfs/tmp/pear/install/grpc/third_part
y/nanopb -I/Volumes/BuildData/tmpfs/tmp/pear/install/grpc/third_party/upb -I/Volumes/BuildData/tmpfs/tmp/pear/install/grpc/third_party/upb/generated_for_cmake -DHAVE_CONFIG_H -Wall -Werror -Wno-parentheses-equality -Wno-unused-value -std=c11 -g -O2 -D PB_FIELD_32BIT=1 -c /Volumes/BuildData/tmpfs/tmp/pear/install/grpc/src/core/ext/upb-generated/src/proto/grpc/gcp/altscontext.upb.c  -fno-common -DPIC -o src/core/ext/upb-generated/src/proto/grpc/gcp/.libs/altscontext.o
/Volumes/BuildData/tmpfs/tmp/pear/install/grpc/src/core/ext/upb-generated/src/proto/grpc/gcp/altscontext.upb.c:10:10: fatal error: 'upb/msg.h' file not found
#include "upb/msg.h"
         ^~~~~~~~~~~
1 error generated.
make: *** [src/core/ext/upb-generated/src/proto/grpc/gcp/altscontext.lo] Error 1

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Aug 8, 2019

It also broke several linux distribtests:
https://source.cloud.google.com/results/invocations/14c1af48-0069-449d-bc60-09f7736fe24d/targets/github%2Fgrpc/tests

@jtattermusch jtattermusch mentioned this pull request Aug 8, 2019
Merged
This was referenced Aug 8, 2019
Merged
Merged
Merged
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a11r a11r Awaiting requested review from a11r

@apolcyn apolcyn Awaiting requested review from apolcyn

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

@vjpai vjpai Awaiting requested review from vjpai

2 more reviewers

@AspirinSJL AspirinSJL AspirinSJL approved these changes

@nicolasnoble nicolasnoble nicolasnoble approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@veblush @jtattermusch @AspirinSJL @nicolasnoble