Add a test client for certain grpclb fallback scenarios#19623
Merged
apolcyn merged 2 commits intogrpc:masterfrom Jul 12, 2019
Merged
Add a test client for certain grpclb fallback scenarios#19623apolcyn merged 2 commits intogrpc:masterfrom
apolcyn merged 2 commits intogrpc:masterfrom
Conversation
867fbd2 to
4999420
Compare
yang-g
approved these changes
Jul 12, 2019
| } | ||
|
|
||
| void RunFallbackAfterStartupTest( | ||
| const std::string break_lb_and_backend_conns_cmd) { |
| } | ||
|
|
||
| void RunFallbackBeforeStartupTest( | ||
| const std::string break_lb_and_backend_conns_cmd, |
| socklen_t len = sizeof(newval); | ||
| if (0 != getsockopt(fd, IPPROTO_TCP, TCP_USER_TIMEOUT, &newval, &len) || | ||
| newval != timeout) { | ||
| gpr_log(GPR_ERROR, "Failed to set socket option TCP_USER_TIMEOUT"); |
Contributor
Author
There was a problem hiding this comment.
done, slightly reworded
| grpc::CreateCustomChannel(FLAGS_server_uri, channel_creds, channel_args)); | ||
| } | ||
|
|
||
| void RunCommand(const std::string command) { |
tools/run_tests/generated/tests.json
Outdated
| "linux", | ||
| "mac", | ||
| "posix", | ||
| "windows" |
Contributor
There was a problem hiding this comment.
Not sure it matters but I suspect this will not run under windows?
Contributor
Author
There was a problem hiding this comment.
good point, restricted to linux only - this test is indeed only meant for linux
Contributor
Author
|
Comments addressed, thanks for the quick review! |
This was referenced Jul 12, 2019
Contributor
Author
|
C/C++ macos: #19614 |
This was referenced Jul 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This synchronizes upstream test protos from grpc/grpc-proto#55 and grpc/grpc-proto#56, and then adds a new one-off test client.
Checking this test into this repo is mostly done to simply the build process - the runner for this test will live outside of this repo. Also note this has been manually tested.