Use grpc_error defs instead of NULL#19572
Merged
nanahpang merged 1 commit intogrpc:masterfrom Jul 11, 2019
Merged
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
weiyongji
reviewed
Jul 10, 2019
NULL is not clear for a grpc_error. Not sure we should use other error codes here.
nanahpang
reviewed
Jul 11, 2019
Contributor
There was a problem hiding this comment.
Yes, I agree that we should change it to GRPC_ERROR_NONE even though they are the same thing here. For readability and avoiding errors when GRPC_ERROR_NONE is assigned to another value, it is better to clarify it now. Thanks for pointing this out. LGTM
nanahpang
approved these changes
Jul 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NULL is not clear for a grpc_error. Not sure we should use other error
codes here.