Re-add GCE DNS integration test scripts#19459
Closed
apolcyn wants to merge 4 commits intogrpc:masterfrom
Closed
Conversation
12538f5 to
de4552f
Compare
large AAAA record test case
de4552f to
4ba8b23
Compare
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 180 days. It will be closed automatically if no further update occurs in 1 day. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests were removed a while ago in fd1a660#diff-97acadf1dc278d5f8a812e74251580e2, but it's now OK to bring them back again.
This provides a repro script for the bug fixed in #19397, running the tests against GCE DNS proves to be able to hit certain bugs that might not be hit with the local DNS server.
Note that the "GCE DNS integration tests" here aren't ran continuously, instead, this PR just adds scripts that try to make it easier to run them manually.