Skip to content

Roll Dart to 2.3#19419

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
mit-mit:bumpdart
Jun 28, 2019
Merged

Roll Dart to 2.3#19419
jtattermusch merged 1 commit intogrpc:masterfrom
mit-mit:bumpdart

Conversation

@mit-mit
Copy link
Copy Markdown
Contributor

@mit-mit mit-mit commented Jun 20, 2019 •
edited by jtattermusch
Loading

Should fix #16580

@mit-mit
Copy link
Copy Markdown
Contributor Author

mit-mit commented Jun 20, 2019

cc @jtattermusch it's not clear to me why tests are failing, e.g.:

Using default tag: latest
Error response from daemon: pull access denied for grpctesting/grpc_interop_dart_4c2921fdf63f6b338ed13faa0b148ed745e93343, repository does not exist or may require 'docker login'

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Jun 24, 2019

@mit-mit when updating the docker images, one must run tools/dockerfile/push_docker_images.sh.
I've done so just no, so I'll respawn the tests and see how that goes.

jtattermusch
jtattermusch approved these changes Jun 24, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once interop tests are green.

@jtattermusch jtattermusch added the release notes: no Indicates if PR should not be in release notes label Jun 24, 2019
@mit-mit
Copy link
Copy Markdown
Contributor Author

mit-mit commented Jun 24, 2019

cc @sigurdm, looks like interop tests are still failing with Dart 2.3

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Jun 24, 2019

Problems:

  • looks like jwt_token_creds test is failing for dart
  • some problem with dart client for a portion of tests:
gRPC Error (14, Error connecting: type 'String' is not a subtype of type 'bool')
#0      Tester.clientStreaming (package:interop/src/client.dart:379:22)
<asynchronous suspension>
#1      Tester.runTestCase (package:interop/src/client.dart:125:16)
<asynchronous suspension>
#2      Tester.runTest (package:interop/src/client.dart:108:11)
<asynchronous suspension>
#3      main (file:///var/local/git/grpc-dart/interop/bin/client.dart:107:20)
<asynchronous suspension>
#4      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#5      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)

and

Unhandled exception:
Bad state: Future already completed
#0      _AsyncCompleter.complete (dart:async/future_impl.dart:39:31)
#1      Tester.cancelAfterFirstResponse.<anonymous closure> (package:interop/src/client.dart:1138:17)
#2      _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10)
#3      _BufferingStreamSubscription._sendError.sendError (dart:async/stream_impl.dart:358:15)
#4      _BufferingStreamSubscription._sendError (dart:async/stream_impl.dart:373:16)
#5      _DelayedError.perform (dart:async/stream_impl.dart:602:14)
#6      _StreamImplEvents.handleNext (dart:async/stream_impl.dart:707:11)
#7      _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:667:7)
#8      _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#9      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#10     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:116:13)
#11     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:173:5)

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Jun 26, 2019

@mit-mit @sigurdm can you take a look at the failures and try to resolve them? We need this fix quickly because currently the entire interop build is failing on our CI.

@sigurdm
Copy link
Copy Markdown

sigurdm commented Jun 27, 2019

I have made grpc/grpc-dart#207 and grpc/grpc-dart#208
So now

tools/run_tests/run_interop_tests.py -l dart -s dart --use_docker

Succeeds for me locally.

@muxi muxi mentioned this pull request Jun 27, 2019
Merged
@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Jun 28, 2019

There are still two issues:

first one is against grpc-dotnet
https://source.cloud.google.com/results/invocations/d3ce41d9-91d6-40e5-a284-7265c5e69222/targets/github%2Fgrpc%2Finterop_test/tests

and the dart jwt_token_creds interop tests seems to be broken
https://source.cloud.google.com/results/invocations/8203e6c9-2740-45b1-b8ee-0afd162da7d9/targets/github%2Fgrpc%2Finterop_test/tests;group=tests;test=cloud_to_prod_auth:dart:default:jwt_token_creds:tls;row=1

I will still merge this PR as it at least improves the situation (the build now succeeds).

@jtattermusch jtattermusch merged commit 8fe1abe into grpc:master Jun 28, 2019
@jtattermusch jtattermusch mentioned this pull request Jun 28, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@apolcyn apolcyn Awaiting requested review from apolcyn

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jtattermusch jtattermusch

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

interop tests: build_docker_dart is broken on master

4 participants

@mit-mit @jtattermusch @sigurdm @grpc-kokoro