Fix data race, heap use-after-free issue in bm_chttp2_transport#19342
Merged
yashykt merged 2 commits intogrpc:masterfrom Jun 17, 2019
Merged
Fix data race, heap use-after-free issue in bm_chttp2_transport#19342yashykt merged 2 commits intogrpc:masterfrom
yashykt merged 2 commits intogrpc:masterfrom
Conversation
Member
Author
Contributor
|
The other benchmark cases use a stack allocated Stream object, they could suffer from the same issue too right? |
Member
Author
|
You are right. It could. I'll just convert all to heap allocate the stream |
Contributor
|
Need a push? |
yang-g
approved these changes
Jun 17, 2019
Member
Author
|
Interop failures are due to failures in building java, dart docker images |
Member
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18416
The issue is that we are relying on the closures being scheduled on the exec_ctx for correctness. If the closures end up being scheduled on the executor thread, then we might end up destroying the Stream object before the grpc stream is freed.
The fix is to simply delete the Stream after the grpc stream is done being destroyed.