Use kokoro env variable to get the PRs target branch#19120
Merged
jtattermusch merged 1 commit intogrpc:masterfrom May 23, 2019
Merged
Use kokoro env variable to get the PRs target branch#19120jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch merged 1 commit intogrpc:masterfrom
Conversation
e999e96 to
39b331d
Compare
Contributor
Author
39b331d to
019e9a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turns out kokoro provides the base branch for PRs through an environment variable
KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCHso there's no need for querying the github API ourselves (and parsing the response with jq).Fixes #18968. Supersedes #19112 and #19062.
This also gets rid of of all the mentions of
ghprbTargetBranchenv variable which dates back to the times when we were still using Jenkins (the var used to be set by Jenkins' github pull request builder plugin).