Fix node interop build scripts#19006
Merged
murgatroid99 merged 1 commit intogrpc:masterfrom May 10, 2019
Merged
Conversation
nicolasnoble
approved these changes
May 10, 2019
Member
Author
|
Re-running tests with grpc/grpc-node#862 merged. |
Member
Author
|
Trying again with grpc/grpc-node#865 merged. |
Member
Author
|
The interop failures are now test failures instead of build failures, which is a success for this PR. I'm just merging it. |
Contributor
|
@murgatroid99, is this needed in v1.21.x? If yes, can you please merge? |
Contributor
|
@srini100 not really, no. |
This was referenced May 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #15464 in combination with grpc/grpc-node#862.