Skip to content

Move ProtoServerReflectionPlugin from grpc to grpc_impl namespace#18600

Merged
karthikravis merged 3 commits intogrpc:masterfrom
karthikravis:grpc_namespace_proto_server
Apr 3, 2019
Merged

Move ProtoServerReflectionPlugin from grpc to grpc_impl namespace#18600
karthikravis merged 3 commits intogrpc:masterfrom
karthikravis:grpc_namespace_proto_server

Conversation

@karthikravis
Copy link
Copy Markdown
Contributor

No description provided.

@karthikravis karthikravis self-assigned this Apr 1, 2019
@karthikravis karthikravis added the release notes: no Indicates if PR should not be in release notes label Apr 1, 2019
@karthikravis karthikravis requested a review from mhaidrygoog April 3, 2019 21:48
@@ -0,0 +1,55 @@
/*
*
* Copyright 2015 gRPC authors.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2019?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh.. my merge and your comment collided.. I will fix in a future PR, apologies.

@karthikravis karthikravis merged commit 9b312aa into grpc:master Apr 3, 2019
@karthikravis karthikravis deleted the grpc_namespace_proto_server branch April 3, 2019 22:33
@lock lock bot locked as resolved and limited conversation to collaborators Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants