Move create_channel_posix from grpc to grpc_impl namespace#18373
Merged
karthikravis merged 8 commits intomasterfrom Mar 29, 2019
Merged
Move create_channel_posix from grpc to grpc_impl namespace#18373karthikravis merged 8 commits intomasterfrom
karthikravis merged 8 commits intomasterfrom
Conversation
30409e2 to
4b0175f
Compare
|
|
||
| namespace grpc { | ||
|
|
||
| #ifdef GPR_SUPPORT_CHANNELS_FROM_FD |
Contributor
There was a problem hiding this comment.
I never realized we had that. Gosh this is ugly. We should make a note to clean this up later.
Rule of thumb: no public API should be behind an ifdef like this. The actual implementation might differ depending on said define, and assert with a message saying this feature isn't enabled in this version, but the API/ABI shouldn't mutate depending on a compilation flag.
nicolasnoble
approved these changes
Mar 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.