Skip to content

Revert "Add basic benchmark test for Python"#17854

Merged
lidizheng merged 1 commit intomasterfrom
revert-17793-py-bm
Jan 29, 2019
Merged

Revert "Add basic benchmark test for Python"#17854
lidizheng merged 1 commit intomasterfrom
revert-17793-py-bm

Conversation

@lidizheng
Copy link
Copy Markdown
Contributor

Reverts #17793
Fixes #17850

This test is tested locally with Python 3, the behavior of the Kokoro job needs investigation. We should revert this test to prevent further test failures.

@jtattermusch

@lidizheng lidizheng added kind/bug lang/Python release notes: no Indicates if PR should not be in release notes labels Jan 29, 2019
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lidizheng lidizheng merged commit 5884861 into master Jan 29, 2019
@vjpai
Copy link
Copy Markdown
Contributor

vjpai commented Jan 29, 2019

Additionally, please don't roll-forward this until you add a license notice in src/python/grpcio_tests/tests/qps/BUILD

@jtattermusch jtattermusch deleted the revert-17793-py-bm branch February 1, 2019 20:16
@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/infra kind/bug lang/Python release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bazel Basic Tests for Python (Local) failure //src/python/grpcio_tests/tests/qps:basic_benchmark_test

5 participants