Skip to content

Fix for macOS build#17839

Merged
lidizheng merged 2 commits intogrpc:masterfrom
lidizheng:issue-17831
Jan 28, 2019
Merged

Fix for macOS build#17839
lidizheng merged 2 commits intogrpc:masterfrom
lidizheng:issue-17831

Conversation

@lidizheng
Copy link
Copy Markdown
Contributor

@lidizheng lidizheng commented Jan 28, 2019

Cast the str type of output_dir if it is unicode.
See if it fixed #17831.

@lidizheng lidizheng added kind/bug lang/Python release notes: no Indicates if PR should not be in release notes labels Jan 28, 2019
@lidizheng
Copy link
Copy Markdown
Contributor Author

The bug is introduced by setuptools 40.7.0 yesterday with an attempt to support non-ASCII setup.cfg file at pypa/setuptools@b31997d.

@lidizheng lidizheng merged commit ec7d669 into grpc:master Jan 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python build broken on MacOS workers

2 participants