Register for cq avalanching when interceptors are going to be run#17806
Merged
yashykt merged 6 commits intogrpc:masterfrom Jan 29, 2019
Merged
Register for cq avalanching when interceptors are going to be run#17806yashykt merged 6 commits intogrpc:masterfrom
yashykt merged 6 commits intogrpc:masterfrom
Conversation
Contributor
|
Nice catch! Does this patch fix the crash observed by the user, and does this test change fail without the code change and pass with the code change? |
Member
Author
|
Yes, the test change fails without the code change, and also fixes the crash observed by the user |
vjpai
suggested changes
Jan 28, 2019
vjpai
approved these changes
Jan 29, 2019
Member
Author
Member
Author
|
Thanks for reviewing! |
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug was discovered today where if the completion queue is shutdown before some tags are returned, then in those cases gRPC ends up asserting inside gRPC Core.
E0122 15:02:57.424189 49066 call.cc:1512] assertion failed: grpc_cq_begin_op(call->cq, notify_tag)
This happened because the interception API needs to generate more batches that need to go through the completion queue and if the shutdown happens before the interception API is done generating all the batches, we will get this error.
This can be avoided by delaying completion queue shutdown till the point that we can generate additional batches.