Skip to content

Cancel still-active c-ares queries after a timeout, for 1.17.x#17382

Merged
apolcyn merged 1 commit intogrpc:v1.17.xfrom
apolcyn:backport_17354
Dec 5, 2018
Merged

Cancel still-active c-ares queries after a timeout, for 1.17.x#17382
apolcyn merged 1 commit intogrpc:v1.17.xfrom
apolcyn:backport_17354

Conversation

@apolcyn
Copy link
Copy Markdown
Contributor

@apolcyn apolcyn commented Dec 3, 2018

Backports #17354 to 1.17.x

@apolcyn apolcyn added area/core lang/core release notes: yes Indicates if PR needs to be in release notes labels Dec 3, 2018
@grpc-testing
Copy link
Copy Markdown

****************************************************************

libgrpc.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.0%    +306 [None]                                                                               +1.75Ki  +0.0%
   +14%    +358 src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_ev_driver.cc          +358   +14%
      [NEW]    +611 grpc_ares_ev_driver_create_locked                                                       +611  [NEW]
      +600%    +150 grpc_ares_ev_driver_start_locked                                                        +150  +600%
      [NEW]    +134 on_timeout_locked                                                                       +134  [NEW]
      +189%     +17 grpc_ares_ev_driver_on_queries_complete_locked                                           +17  +189%
      +9.9%      +8 [Unmapped]                                                                                +8  +9.9%
  +1.6%     +64 src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc             +64  +1.6%
       +11%     +64 grpc_core::(anonymous namespace)::AresDnsResolverFactory::CreateResolver(grpc_core::     +64   +11%
      +3.3%      +8 grpc_core::(anonymous namespace)::AresDnsResolver::StartResolvingLocked                   +8  +3.3%
  +0.3%     +16 src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc             +16  +0.3%
      [NEW] +1.33Ki grpc_dns_lookup_ares_continue_after_check_localhost_and_ip_literals_locked           +1.33Ki  [NEW]
      [NEW]    +808 grpc_dns_lookup_ares_locked_impl                                                        +808  [NEW]
       +10%      +7 [Unmapped]                                                                                +7   +10%
      +1.8%      +1 grpc_resolve_address_invoke_dns_lookup_ares_locked                                        +1  +1.8%

  +0.0%    +744 TOTAL                                                                                +2.18Ki  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link
Copy Markdown

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,496      Total (=)      2,020,496

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,633      Total (>)     11,175,632

 No significant differences in binary sizes


@grpc-testing
Copy link
Copy Markdown

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@apolcyn apolcyn merged commit 0889573 into grpc:v1.17.x Dec 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/core lang/core release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants