Skip to content

Add fork tests as Python unit tests#16513

Merged
ericgribkoff merged 2 commits intogrpc:masterfrom
ericgribkoff:python_unit_fork_tests
Feb 16, 2019
Merged

Add fork tests as Python unit tests#16513
ericgribkoff merged 2 commits intogrpc:masterfrom
ericgribkoff:python_unit_fork_tests

Conversation

@ericgribkoff
Copy link
Copy Markdown
Contributor

@ericgribkoff ericgribkoff commented Aug 30, 2018 •
edited
Loading

This includes the fork interop test cases as part of the Python unit test suite. The test pre-fork a local test interop server, and set the polling strategy to epoll1 on Linux and poll on Mac.

@ericgribkoff ericgribkoff added disposition/DO NOT MERGE release notes: no Indicates if PR should not be in release notes lang/Python labels Aug 30, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,754      Total (>)     10,843,745

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,757      Total (>)     10,843,747

 No significant differences in binary sizes

@ericgribkoff ericgribkoff force-pushed the python_unit_fork_tests branch from b145d59 to 758b822 Compare August 30, 2018 19:04
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,755      Total (<)     10,843,757

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,752      Total (>)     10,843,747

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,760      Total (>)     10,843,752

 No significant differences in binary sizes

@ericgribkoff ericgribkoff force-pushed the python_unit_fork_tests branch 3 times, most recently from d902421 to 828af73 Compare August 30, 2018 22:05
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,755      Total (>)     10,843,749

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,752      Total (>)     10,843,750

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,754      Total (>)     10,843,751

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,757      Total (>)     10,843,748

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,755      Total (>)     10,843,752

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,755      Total (>)     10,843,749

 No significant differences in binary sizes

@ericgribkoff ericgribkoff mentioned this pull request Feb 7, 2019
Merged
@ericgribkoff ericgribkoff force-pushed the python_unit_fork_tests branch from fd9af51 to 48102c7 Compare February 7, 2019 21:48
@ericgribkoff ericgribkoff assigned gnossen and unassigned mehrdada Feb 7, 2019
@ericgribkoff ericgribkoff requested a review from gnossen February 7, 2019 21:49
@ericgribkoff
Copy link
Copy Markdown
Contributor Author

ericgribkoff commented Feb 7, 2019

@gnossen PTAL. The changes to core in the first commit can be ignored; it is under separate review at #17973

@ericgribkoff ericgribkoff mentioned this pull request Feb 7, 2019
Closed
gnossen
gnossen reviewed Feb 8, 2019
View reviewed changes
src/python/grpcio_tests/commands.py Outdated
Copy link
Copy Markdown
Contributor

@gnossen gnossen Feb 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Copy Markdown
Contributor Author

@ericgribkoff ericgribkoff Feb 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, no. Fixed.

@ericgribkoff ericgribkoff force-pushed the python_unit_fork_tests branch from ade8226 to d36adc4 Compare February 9, 2019 01:50
@ericgribkoff ericgribkoff mentioned this pull request Feb 9, 2019
Closed
@ericgribkoff ericgribkoff force-pushed the python_unit_fork_tests branch 13 times, most recently from 58f9487 to 6e2e39e Compare February 14, 2019 21:25
This was referenced Feb 15, 2019
Merged
Closed
@ericgribkoff ericgribkoff force-pushed the python_unit_fork_tests branch from 6e2e39e to 2ea6d3e Compare February 15, 2019 17:51
@ericgribkoff
Copy link
Copy Markdown
Contributor Author

ericgribkoff commented Feb 15, 2019

@gnossen This should be (finally...) ready for review. I filed #18075 to track the issues with 3.7, and for now these tests will only run on Python 2 - but this is far better than nothing, as it would have caught the fork-support breakage fixed-after-the-fact by #17973 and does catch a breakage in the in-progress #17308.

gnossen
gnossen requested changes Feb 16, 2019
View reviewed changes
@ericgribkoff ericgribkoff merged commit b794777 into grpc:master Feb 16, 2019
@ericgribkoff ericgribkoff deleted the python_unit_fork_tests branch February 16, 2019 02:31
@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gnossen gnossen gnossen approved these changes

+1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gnossen gnossen

Labels

lang/Python release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericgribkoff @grpc-testing @mehrdada @gnossen @grpc-kokoro