Skip to content

Revert "Use heuristic to determine how many events to handle per iter…#14688

Merged
kpayson64 merged 1 commit intogrpc:masterfrom
kpayson64:revert_pr
Mar 14, 2018
Merged

Revert "Use heuristic to determine how many events to handle per iter…#14688
kpayson64 merged 1 commit intogrpc:masterfrom
kpayson64:revert_pr

Conversation

@kpayson64
Copy link
Copy Markdown
Contributor

@kpayson64 kpayson64 commented Mar 13, 2018

…ation"

This reverts commit be619a3.

The supposed improvement in plaque benchmarks was just noise, and this hurts our unary 62 channel 0 byte synthetic benchmark

@kpayson64 kpayson64 requested a review from sreecha March 13, 2018 17:00
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Mar 13, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                              FILE SIZE
 ++++++++++++++ GROWING                                ++++++++++++++

 -------------- SHRINKING                              --------------
  [ = ]       0 [None]                                    -600  -0.0%
  -2.0%    -224 src/core/lib/iomgr/ev_epollex_linux.cc    -224  -2.0%
     -29.1%    -189 pollable_process_events                   -189 -29.1%
      -0.7%     -14 pollset_work                               -14  -0.7%
      -3.8%     -13 [Unmapped]                                 -13  -3.8%
      -9.6%      -8 pollset_init                                -8  -9.6%

  -0.0%    -224 TOTAL                                     -824  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Mar 13, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Mar 13, 2018 

[microbenchmarks] Performance differences noted:
Benchmark                                                               allocs_per_iteration    atm_add_per_iteration    atm_cas_per_iteration    locks_per_iteration    nows_per_iteration
----------------------------------------------------------------------  ----------------------  -----------------------  -----------------------  ---------------------  --------------------
BM_EmptyCore                                                                                    -22%
BM_PollEmptyPollset                                                                             -40%
BM_SingleThreadPollOneFd                                                                        -39%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/0/0                                                                                        +20%                   +16%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/0/1                                                                                        +11%                   +12%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/0/2                                                                                        +8%                    +9%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/1/1                                                                                        +11%                   +12%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/1/2                                                                                        +8%                    +9%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/262144/1                                                                                   +10%                   +12%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/262144/2                                                                                   +7%                    +9%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/32768/1                                                                                    +11%                   +12%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/32768/2                                                                                    +7%                    +9%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/4096/1                                                                                     +11%                   +12%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/4096/2                                                                                     +7%                    +9%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/512/1                                                                                      +11%                   +12%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/512/2                                                                                      +7%                    +9%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/64/1                                                                                       +11%                   +12%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/64/2                                                                                       +7%                    +9%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/8/1                                                                                        +11%                   +12%
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/8/2                                                                                        +8%                    +9%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/0/0                                                                                           +20%                   +16%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/0/1                                                                                           +11%                   +12%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/0/2                                                                                           +8%                    +9%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/1/1                                                                                           +11%                   +12%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/1/2                                                                                           +8%                    +9%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/2097152/1                                                                                     +8%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/262144/1                                                                                      +11%                   +12%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/262144/2                                                                                      +7%                    +9%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/32768/1                                                                                       +11%                   +12%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/32768/2                                                                                       +7%                    +9%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/4096/1                                                                                        +11%                   +12%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/4096/2                                                                                        +7%                    +9%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/512/1                                                                                         +11%                   +12%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/512/2                                                                                         +7%                    +9%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/64/1                                                                                          +11%                   +12%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/64/2                                                                                          +7%                    +9%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/8/1                                                                                           +11%                   +12%
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/8/2                                                                                           +8%                    +9%
BM_UnaryPingPong<MinTCP, NoOpMutator, NoOpMutator>/0/2097152                                                                                      +15%                   +4%
BM_UnaryPingPong<MinTCP, NoOpMutator, NoOpMutator>/134217728/134217728  -55%                    -59%                     -59%                     -56%
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/0/2097152                                                                                         +18%                   +6%
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/134217728/0             -59%                    -62%                     -62%                     -62%
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/134217728/134217728     -49%                    -48%                     -49%                     -45%

@kpayson64
Copy link
Copy Markdown
Contributor Author

kpayson64 commented Mar 14, 2018

#14268

@kpayson64 kpayson64 merged commit f60cbbd into grpc:master Mar 14, 2018
@AspirinSJL AspirinSJL mentioned this pull request Apr 5, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
@lock lock bot unassigned sreecha Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sreecha sreecha sreecha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kpayson64 @grpc-testing @sreecha